Add support for NVM_SILENT environment variable#91
Open
regulskimichal wants to merge 1 commit into
Open
Conversation
|
@lukechilds please consider merging this. |
gentslava
suggested changes
Oct 19, 2023
gentslava
left a comment
gentslava
left a comment
There was a problem hiding this comment.
Your code always works in silent mode because of mistake.
| nvm install && export NVM_AUTO_USE_ACTIVE=true | ||
| elif [[ "$nvmrc_node_version" != "$node_version" ]]; then | ||
| nvm use && export NVM_AUTO_USE_ACTIVE=true | ||
| if [[ "$NVM_SILENT" = true ]]; then |
There was a problem hiding this comment.
This is an assignment instead of a condition.
| elif [[ "$node_version" != "$(nvm version default)" ]] && [[ "$NVM_AUTO_USE_ACTIVE" = true ]]; then | ||
| echo "Reverting to nvm default version" | ||
| nvm use default | ||
| if [[ "$NVM_SILENT" = true ]]; then |
|
@regulskimichal would be great to have this, if you can spare the time fixing the remarks |
brianmgray
added a commit
to brianmgray/zsh-nvm
that referenced
this pull request
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add a feature that disables some messages while switching between multiple versions of node. I use powerlevel10k theme that already prints versions of node so I find it useful to make it possible to disable some verbose messages.