some ideas for making placeholders read only #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lukesmurray
commented
Jun 3, 2021
There was a problem hiding this comment.
- Styling needs to be parameterized
- Read only behavior needs to be parameterized
- open questions
- can you delete a read only void element in a snippet? If I backspace in a placeholder maybe lock backspace to the placeholder, same with navigated (left, right arrow etc),
- If you click on a part of a snippet that isn't a placeholder should you select the entire snippet? should you select the nearest placeholder?
- can we normalize void elements so they are merged together if they are adjacent to each other with no placeholder in between
- can we link the void element text to the "snippet definition" following the component metaphor?
| <span | ||
| style={{ | ||
| padding: '0px 1px', | ||
| border: `2px solid ${leaf.isFinalTabStop ? 'grey' : placeholderColor}`, |
There was a problem hiding this comment.
final tab stop styling should be parameterized, also styling for empty/non empty placeholders should be parameterized
Comment on lines
+18
to
+26
| style={{ | ||
| padding: '3px 3px 2px', | ||
| margin: '0 1px', | ||
| verticalAlign: 'baseline', | ||
| display: 'inline-block', | ||
| borderRadius: '4px', | ||
| backgroundColor: '#eee', | ||
| fontSize: '0.9em', | ||
| boxShadow: selected && focused ? '0 0 0 2px #B4D5FF' : 'none', |
There was a problem hiding this comment.
styling for read only snippet should be parameterized
Comment on lines
+256
to
+260
| result.push({ | ||
| children: [{ text: v }], | ||
| type: 'SnippetReadonlyText', | ||
| label: v, | ||
| }); |
There was a problem hiding this comment.
should parameterize whether or not snippet text is read only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.