Conversation
…evidence family New `### Proposal-path enumeration goes stale when proposal commits to main first — anchor to scope invariant` sibling clause under `## Verification-evidence family` in `docs/ac-rigor-reference.md`, documenting the cross-branch merge-base failure mode that bit task-9cd6cdb9 (PR #490) round 1: when the proposal commit lands on `main` before the implementation branch forks, a literal four-path enumeration AC silently fails because `main...HEAD` returns only the implementation paths. Prescribes the (b)-form scope invariant ("no `src/**`, no `scripts/**`, no `templates/**`, no `*.test.ts`") as the durable AC shape — what's NOT in the diff survives a merge-base advance — and documents the same-PR proposal-edit recovery for coders who hit the failure mode mid-round. Cross-links the sibling `### Diff-enumerated verification lines go stale` clause (same toolset, distinct trigger). Promotes the clause-count line from "sixteen" to "seventeen" clauses, and adds the new clause title to `skills/worker-conventions.md`'s family-grouped pointer (Process-around-the-AC bullet) so workers landing there discover both clauses together. Negative control: `skills/ludics-draft-proposal-worker.md` is unchanged; the worker prompt's existing "consult `docs/ac-rigor-reference.md`" hook is the entry point per `feedback_reference_layer_not_inline.md`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@codex review Focus on bugs, correctness issues, and edge cases. Do not check adherence to a spec or plan. |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Suggest Refactor — task-097cca67 / PR #498 retrospectiveWhat I'd do differently next time, ordered by leverage: 1. Absorb the reciprocal cross-link (one-line addition I deferred)The new 2. The clause-count line is a drift hazard worth retiring
3. (b)-form scope invariants need explicit "verify post-commit" guidanceAC10 of this proposal modelled the (b)-form invariant the new clause prescribes — "no 4. Eat-your-own-dog-food is a teachable proposal-authoring patternThe proposal's AC10 instantiated the (b)-form invariant the clause prescribes — "the (b)-form this proposal is itself prescribing — eats its own dog food." This is a deliberate authoring pattern that's currently undocumented anywhere and would belong as a one-line addition to either 5. Branch state inspection should precede AC10-shape verificationsBefore running any Strengths to preserve (not for change, for memory)
|
Summary
### Proposal-path enumeration goes stale when proposal commits to main first — anchor to scope invariantclause under## Verification-evidence familyindocs/ac-rigor-reference.md, documenting the cross-branch merge-base failure mode that hit task-9cd6cdb9 (PR docs: lockstep contract-prose rewrite + stash-prod mutation-test clauses #490) round 1.src/**, noscripts/**, notemplates/**, no*.test.ts") as the durable AC shape, plus the same-PR proposal-edit recovery; cross-links the sibling### Diff-enumerated verification lines go staleclause (same toolsetgit diff --name-only main...HEAD, distinct trigger: cross-branch merge-base advance vs within-branch growth).skills/worker-conventions.md's family-grouped pointer (Process-around-the-AC bullet).skills/ludics-draft-proposal-worker.mdunchanged. AC-shape guidance lives at the reference layer perfeedback_reference_layer_not_inline.md.Test plan
awk '/^## Verification-evidence family/{p=1;next} p && /^## /{exit} p' docs/ac-rigor-reference.md | grep -F "### Proposal-path enumeration goes stale when proposal commits to main first"returns 1; same slice contains### Diff-enumerated.grep -F "before the implementation"hits the new clause body.grep -F "scope invariant"ANDgrep -F "no \src/**`"` hit inside the new clause.grep -F "task-9cd6cdb9"ANDgrep -F "PR #490"both hit inside the new clause.Diff-enumeratedcross-link in body;same toolset,distinct trigger,merge-baseall present.same-PRandsame PRboth hit inside the recovery sentence.grep -F "Proposal-path enumeration goes stale when proposal commits to main first" skills/worker-conventions.mdreturns 1 hit (line 49).grep -F "sixteen clauses"returns 0;grep -F "seventeen clauses"returns 1.git diff --name-only main...HEADhas noskills/ludics-draft-proposal-worker.md.git diff --name-only main...HEADmatches nosrc/**,scripts/**,templates/**, or*.test.tspaths; onlydocs/ac-rigor-reference.mdandskills/worker-conventions.md.🤖 Generated with Claude Code