Feature/add id check for new flash chip BY25Q32ESWIG#25
Conversation
added 2 commits
April 10, 2026 08:45
…new pinetime devices with that chip
Owner
|
Hmm, something something outdated dependencies. It's been a while since CI ran 😅 |
Author
|
Seems to me that Rust just needs to be updated to a newer version? In the rust-toolchain.toml But that is kinda weird, why the Ci would fail, if a local build is fine, as the toolchain.toml always pins the version. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a manufacturer id check for the new flash chip BY25Q32ESWIG. Without the new manufacturer id check, the bootloader will fail to load the image for new devices with the new flash chip, and revert back to loading Infinitime.
The change for the new chip is documented here:
InfiniTimeOrg/InfiniTime#2096
(Side note: Completely omitting both manufacturer id checks will still boot into watchful)