Skip to content

Unused grid label logic #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graycrawford merged 1 commit into from
Mar 2, 2026
Merged

Unused grid label logic #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions packages/tldraw/src/lib/tools/SelectTool/childStates/PointingShape.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Group2d, StateNode, TLPointerEventInfo, TLShape } from '@tldraw/editor'
import { StateNode, TLPointerEventInfo, TLShape } from '@tldraw/editor'
import { isOverArrowLabel } from '../../../shapes/arrow/arrowLabel'
import { getTextLabels } from '../../../utils/shapes/shapes'

Expand All @@ -11,7 +11,6 @@ export class PointingShape extends StateNode {

didCtrlOnEnter = false
didSelectOnEnter = false
didHitGridLabel = false

override onEnter(info: TLPointerEventInfo & { target: 'shape' }) {
const selectedShapeIds = this.editor.getSelectedShapeIds()
Expand All @@ -23,19 +22,6 @@ export class PointingShape extends StateNode {
this.hitShape = info.shape
this.isDoubleClick = false
this.didCtrlOnEnter = accelKey
this.didHitGridLabel = false
if ((info.shape as any).type === 'grid') {
const geometry = this.editor.getShapeGeometry(info.shape)
if (geometry instanceof Group2d) {
const pointInShapeSpace = this.editor.getPointInShapeSpace(info.shape, currentPagePoint)
for (const child of geometry.children) {
if (child.isLabel && child.isPointInBounds(pointInShapeSpace)) {
this.didHitGridLabel = true
break
}
}
}
}
const outermostSelectingShape = this.editor.getOutermostSelectableShape(info.shape)
const selectedAncestor = this.editor.findShapeAncestor(outermostSelectingShape, (parent) =>
selectedShapeIds.includes(parent.id)
Expand Down
Loading