Skip to content

Cmd+drag uses intersection selection, same as normal drag #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaznaan merged 1 commit into from
Mar 2, 2026
Merged

Cmd+drag uses intersection selection, same as normal drag #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tldraw/src/lib/tools/SelectTool/childStates/Brushing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export class Brushing extends StateNode {

// If we're in wrap mode and the brush did not fully encloses the shape, it's a miss
// We also skip frames unless we've completely selected the frame.
if (isWrapping || editor.isShapeFrame(shape)) {
if (editor.isShapeFrame(shape)) {
Copy link
Copy Markdown

@cursor cursor Bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: isWrapping and its dependencies are unused

Low Severity

After removing isWrapping from the condition on line 197, the variable isWrapping (line 127) is now computed but never read. This also makes ctrlKey (line 121), the isWrapMode class property (line 25), its initialization in onEnter (line 36), its destructuring (line 117), and the comment on line 126 all dead code. These should be cleaned up to avoid confusing future readers.

Additional Locations (2)

Fix in Cursor Fix in Web

continue testAllShapes
}

Expand Down
Loading