forked from tldraw/tldraw
-
Notifications
You must be signed in to change notification settings - Fork 0
Add public setUniqueIdGenerator for custom ID generation #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
253d257
Add grid and artifact shape
kaznaan 51dbacb
Export renderer
kaznaan f23f7fa
Add copy script
kaznaan 8530518
Revert hit test for label
kaznaan cbdbb6e
Add public setUniqueIdGenerator to customize ID generation
theop-luma ca0858f
Add utils to pack-and-copy script
theop-luma 79f87f2
Revert "Revert hit test for label"
kaznaan a75b075
Revert "Export renderer"
kaznaan b7e111b
Revert "Add grid and artifact shape"
kaznaan 544f5ec
Merge branch 'luma/v4.4.x' into theop/uniqueId-v2
kaznaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restoreUniqueIdsilently discards custom generator set via public APIMedium Severity
setUniqueIdGeneratorsetsimplto a custom function, butrestoreUniqueIdalways resetsimplback to the hard-codednanoid, not to whatever was set viasetUniqueIdGenerator. If a downstream app configures a custom generator and any code later callsrestoreUniqueId, the custom generator is silently lost.restoreUniqueIdneeds to be aware of the user-configured baseline to restore to the right implementation.Additional Locations (1)
packages/utils/src/lib/id.ts#L117-L120