Skip to content

selecting assets now has no margin #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaznaan merged 4 commits into from
Feb 28, 2026
Merged

selecting assets now has no margin #9

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b6dac7
selecting assets now has no margin
graycrawford Feb 27, 2026
683cf1b
+1 px hover area
kaznaan Feb 28, 2026
4172138
Merge branch 'luma/v4.4.x' into gray/asset-selection-noMargin
kaznaan Feb 28, 2026
a07286e
Revert comment back
kaznaan Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/editor/src/lib/editor/Editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5407,7 +5407,10 @@ export class Editor extends EventEmitter<TLEventMap> {
// If the shape is filled, then it's a hit. Remember, we're
// starting from the TOP-MOST shape in z-index order, so any
// other hits would be occluded by the shape.
return inMarginClosestToEdgeHit || shape
if (distance <= 1) {
Copy link
Copy Markdown

@cursor cursor Bot Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threshold uses 1 instead of 0 for filled shapes

Medium Severity

The PR description states filled shapes hit only when distance <= 0 (cursor actually inside bounds), but the code checks distance <= 1. For closed geometries, positive distance means outside the shape, so distance <= 1 still allows hits up to 1 unit outside the shape boundary — contradicting the stated "no margin bleed" goal in the accompanying comment. The condition likely needs to be distance <= 0.

Fix in Cursor Fix in Web

return inMarginClosestToEdgeHit || shape
}
// Point is outside the filled shape but within margin — skip (no margin bleed)
} else {
// If the shape is bigger than the viewport, then skip it.
if (this.getShapePageBounds(shape)!.contains(viewportPageBounds)) continue
Expand Down
Loading