update guidance about plugin config typing#30
Merged
mrcjkb merged 1 commit intolumen-oss:mainfrom Mar 19, 2026
Merged
Conversation
Member
|
Thanks for your suggestion 🙏 This approach has some potential caveats:
On the other hand, it potentially means less effort in keeping the classes synchronised. |
Contributor
Author
|
Good point! I'll fix up the PR some time this week. |
dc1f359 to
c11e542
Compare
c11e542 to
e625bf5
Compare
Contributor
Author
|
Updated |
mrcjkb
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nowadays,
lua_lssupports(partial)classes, basically you can inherit from another class but make all its fields nullable.For example:
I've used this successfully in a few plugins, it works really nicely.