-
Notifications
You must be signed in to change notification settings - Fork 180
Minor cleanups #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Minor cleanups #171
Conversation
…t just because C::Output was () in other cases?
…ultiple places but inlined
…eral. doc comments
|
What was cleaned up? Please provide details, there are many lines changed |
|
Not too much to say, but I will do so either tomorrow or Monday after can get back to this. Should have put as draft because didn't get to the description part yesterday before context switching. |
…isjoint first and then wire up all at once after that
|
Any more documentation of what was done that you suggest? |
|
Let me know if there is any more wanted written here. This one is mostly about making more idiomatic. I find that once that happens it is much easier for me to add features without having the linter full of extraneous complaints. |
|
I don't think so, I just havent had a chance to review it yet because a good amount of lines were changed. Should have time today or this week! |
|
Whatever happened here? |
We got a little ambitious with our rewrite and it took longer than expected and changed a lot of the api surface. Most of this pr is still applicable though so I'll be merging it in sometime in the next week or so. |
Uh oh!
There was an error while loading. Please reload this page.