Add splat writer #1
Conversation
Untested version of splat writer.
| reporter.SetTotal(file.GetFileSize()); | ||
|
|
||
| //Constants | ||
| constexpr size_t data_size = 32; |
There was a problem hiding this comment.
I think we can call this SPLAT_GAUSSIAN_BYTE_SIZE = 32; and do as a #define
| int numberOfPoints = 0; | ||
|
|
||
| // Vectors to store the data | ||
| std::vector<float> positionVector; |
There was a problem hiding this comment.
Do not use camel case for variables. You can use underscores instead, like "position_vector". Check naming of all variables
There was a problem hiding this comment.
Yeah, use Snake case instead. Something like this snake_case_example
| f_dcVector.insert(f_dcVector.end(), f_dc, f_dc + 3); | ||
| f_restVector.insert(f_restVector.end(), f_rest, f_rest + 3); | ||
|
|
||
| reporter.Update(file.CurPos()); |
There was a problem hiding this comment.
They like to update progress every 1000 iterations
Use a counter:
if (++i % 1000 == 0) {
reporter.Update(file.CurPos());
}
…lo/Open3D into joserochh/issue-7153-dev
- Removed camel casing - define splat gaussian byte size
…oserochh/issue-7153-dev
| reporter.SetTotal(file.GetFileSize()); | ||
|
|
||
| //Constants | ||
| constexpr size_t data_size = 32; |
| int numberOfPoints = 0; | ||
|
|
||
| // Vectors to store the data | ||
| std::vector<float> positionVector; |
There was a problem hiding this comment.
Yeah, use Snake case instead. Something like this snake_case_example
|
Run the following command to check the code style. That needs to match with the one expected for Open3D.
|
Untested version of splat writer.
Type
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description