fix: seq.printall fmt param documented as format string - #519
Merged
Conversation
Agent-Logs-Url: https://github.com/lunarmodules/Penlight/sessions/8e18e663-869b-45c6-b7a5-4d86f6af0a5f Co-authored-by: Tieske <1077043+Tieske@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Tieske
April 3, 2026 08:25
View session
Member
|
@copilot I don't like the fix, just document the parameter to be a string instead of a function |
Agent-Logs-Url: https://github.com/lunarmodules/Penlight/sessions/c46dde20-168b-4b16-9495-0e55bee00fb9 Co-authored-by: Tieske <1077043+Tieske@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
fix: seq.printall
fix: seq.printall Apr 3, 2026
fmt param accepts both format string and functionfmt param documented as format string
Tieske
approved these changes
Apr 3, 2026
|
Hi @Tieske, is it expected for there to be more LLM output incorporated into Penlight in the future? |
Member
|
Probably, minor things like this are easily fixed using copilot etc. What's your concern @McSinyx ? |
|
Mostly concerning copyright, since LLM may output verbatim and near-verbatim copies of its training data. 1+1- patches like this one are unlikely to be eligible for copyright and thus not within my concern though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pl.seq.printall'sfmtparameter was documented as accepting a function, but the implementation only works with a format string passed tostring.format.Changes
lua/pl/seq.lua: Updated the doc comment forfmtfrom "format function" → "format string" to accurately reflect the implementation.