Skip to content

fix: seq.printall fmt param documented as format string - #519

Merged
Tieske merged 2 commits into
masterfrom
copilot/fix-518
Apr 3, 2026
Merged

fix: seq.printall fmt param documented as format string#519
Tieske merged 2 commits into
masterfrom
copilot/fix-518

Conversation

Copilot AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

pl.seq.printall's fmt parameter was documented as accepting a function, but the implementation only works with a format string passed to string.format.

Changes

  • lua/pl/seq.lua: Updated the doc comment for fmt from "format function" → "format string" to accurately reflect the implementation.

@Tieske

Tieske commented Apr 3, 2026

Copy link
Copy Markdown
Member

@copilot I don't like the fix, just document the parameter to be a string instead of a function

Copilot AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot I don't like the fix, just document the parameter to be a string instead of a function

Done — reverted the code change and updated the doc comment to say "format string" instead of "format function" (99f52a6).

Copilot AI changed the title fix: seq.printall fmt param accepts both format string and function fix: seq.printall fmt param documented as format string Apr 3, 2026
Copilot AI requested a review from Tieske April 3, 2026 08:29
@Tieske
Tieske marked this pull request as ready for review April 3, 2026 08:29
@Tieske
Tieske merged commit 09fbf42 into master Apr 3, 2026
22 checks passed
@Tieske
Tieske deleted the copilot/fix-518 branch April 3, 2026 08:30
@McSinyx

McSinyx commented Apr 9, 2026

Copy link
Copy Markdown

Hi @Tieske, is it expected for there to be more LLM output incorporated into Penlight in the future?

@Tieske

Tieske commented Apr 9, 2026

Copy link
Copy Markdown
Member

Probably, minor things like this are easily fixed using copilot etc.

What's your concern @McSinyx ?

@McSinyx

McSinyx commented Apr 9, 2026

Copy link
Copy Markdown

Mostly concerning copyright, since LLM may output verbatim and near-verbatim copies of its training data. 1+1- patches like this one are unlikely to be eligible for copyright and thus not within my concern though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants