tests(http) try and reproduce timeout issue #138 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
force-pushed
the
http
branch
5 times, most recently
from
a51a7f4 to
87fb8f6
Compare
Tieske
force-pushed
the
http
branch
3 times, most recently
from
3f0fd59 to
6b3e7f1
Compare
With Lua 5.1 a pcall gets wrapped in another coroutine (by the coxpcall library), the expired timeouts would resume the wrapped coroutine instead of the original one. This caused one level to little on the stack, and hence timeout errors would bubble up 1 level too many. fixes #138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds some other commits encountered while writing the tests