Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add libreadline-dev dependency #69

Merged
merged 4 commits into from
Feb 13, 2025
Merged

ci: add libreadline-dev dependency #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
662ef75
ci: add libreadline-dev dependency
hishamhm Jan 29, 2025
df9b45d
ci: update bin32 tests to ubuntu22.04
hishamhm Jan 29, 2025
589f1ff
ci: use ubuntu_rolling to avoid aarch64 compiler crash
hishamhm Jan 29, 2025
15de671
ci: try using clang
hishamhm Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/bit32-multi-arch-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@ jobs:
with:
path: .install/${{ matrix.arch }}/lua-${{ matrix.luaVersion }}
key: lua-on-linux-${{ matrix.arch }}-${{ matrix.luaVersion }}
- uses: uraimo/run-on-arch-action@v2.0.7
- uses: uraimo/run-on-arch-action@v2
with:
arch: ${{ matrix.arch }}
distro: ubuntu20.04
distro: ubuntu_rolling
githubToken: ${{ github.token }}
setup: |
mkdir -p ".install/${{ matrix.arch }}"
install: |
apt-get update -q -y
apt-get install -q -y curl unzip build-essential libreadline-dev libncurses-dev
apt-get install -q -y curl unzip build-essential libreadline-dev libncurses-dev clang
rm -rf /var/lib/apt/lists/*
run: |
v() {
Expand All @@ -38,6 +38,7 @@ jobs:
echo -e "\033[0m" >&2
"$@"
}
export CC=clang
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why with clang?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting compiler crashes (as in gcc "internal compiler error" bugs) on non-x86 archs: https://github.com/lunarmodules/lua-compat-5.3/actions/runs/13035598909/job/36365131177

if [ "${{ steps.lua-cache.outputs.cache-hit }}" != true ]; then
(set -o pipefail; cd ".install/${{ matrix.arch }}" && v curl --fail --silent --location "http://www.lua.org/ftp/lua-${{ matrix.luaVersion }}.tar.gz" | tar xzpf -)
(cd ".install/${{ matrix.arch }}/lua-${{ matrix.luaVersion }}" && v make linux)
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/compat53-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
- uses: actions/checkout@v2
- name: install Lua
run: |
sudo apt install libreadline-dev
pip3 install --user hererocks
~/.local/bin/hererocks old --${{ matrix.luaVersion }}
test -e old/bin/lua || (cd old/bin && ln -s luajit* lua)
Expand Down
Loading