Skip to content

Fix Symbol Visibility #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StDymphna wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Symbol Visibility #72

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f0945
Default to exporting API symbols as public/default for compatibility …
StDymphna Nov 15, 2025
447c3e0
Conditionalize LUAMOD_API definition for compilers
StDymphna Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lprefix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
#include "c-api/compat-5.3.h"

#undef LUAMOD_API
#define LUAMOD_API extern
#define LUAMOD_API __attribute__((visibility("default"))) extern

@hishamhm hishamhm Feb 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be wrapped with if defined(__GNUC__) like the other cases below.



#ifdef lutf8lib_c
Expand Down Expand Up @@ -165,7 +165,7 @@ LUAMOD_API int luaopen_compat53_string (lua_State *L) {
*/
# undef LUAMOD_API
# if defined(__GNUC__) || __has_attribute(__unused__)
# define LUAMOD_API __attribute__((__unused__)) static
# define LUAMOD_API __attribute__((__unused__, visibility("default"))) static
# else
# define LUAMOD_API static
# endif
Expand Down Expand Up @@ -274,7 +274,7 @@ LUAMOD_API int luaopen_compat53_io (lua_State *L) {
*/
# undef LUAMOD_API
# if defined(__GNUC__) || __has_attribute(__unused__)
# define LUAMOD_API __attribute__((__unused__)) static
# define LUAMOD_API __attribute__((__unused__, visibility("default"))) static
# else
# define LUAMOD_API static
# endif
Expand Down