Skip to content

add pattern for lfs.dir on WIN32 - #81

Open
uudiin wants to merge 1 commit into
lunarmodules:masterfrom
uudiin:master
Open

add pattern for lfs.dir on WIN32#81
uudiin wants to merge 1 commit into
lunarmodules:masterfrom
uudiin:master

Conversation

@uudiin

@uudiin uudiin commented Sep 16, 2016

Copy link
Copy Markdown

lfs.dir support pattern on Windows;

@coveralls

coveralls commented Sep 16, 2016

Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage remained the same at 78.272% when pulling cdbb640 on uudiin:master into 50919ed on keplerproject:master.

@coveralls

coveralls commented Sep 16, 2016

Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage remained the same at 78.272% when pulling c863b66 on uudiin:master into 50919ed on keplerproject:master.

@hishamhm

Copy link
Copy Markdown
Member

Hi, thanks for contributing!

This feature can only be added if the equivalent functionality is added to the Unix side of the code as well.

It also needs update in the documentation and a test.

Further, since it adds functionality, this PR should target the 1.7 branch.

@hishamhm
hishamhm force-pushed the master branch 2 times, most recently from 9cd10fe to f77f248 Compare June 24, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants