Improve resiliency on 404 responses #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
bugbot run |
Member
Author
|
bugbot run |
mahlunar
reviewed
Dec 11, 2025
| } | ||
|
|
||
| response, err = c.httpClient.Do(req) | ||
| if err != nil || (response != nil && response.StatusCode >= 500) { |
Member
There was a problem hiding this comment.
can response != nil happen when err == nil? I think not?
Comment on lines
+118
to
+121
| for attempt := 0; attempt < 3; attempt++ { | ||
| if attempt > 0 && bodyBytes != nil { | ||
| req.Body = io.NopCloser(bytes.NewReader(bodyBytes)) | ||
| } |
Member
There was a problem hiding this comment.
This for loop could be extracted to a function that gets passed the inner logic so that retries and http response handling is separated
Member
There was a problem hiding this comment.
You might also get more control over response.Body.Close() as you could end up in a construction where you can always defer it instead of handling the separate cases throughout the logic
Comment on lines
165
to
+167
| var jobs []queryJob | ||
| var configs []queryConfig | ||
| var jobsMutex sync.RWMutex |
Member
There was a problem hiding this comment.
nit: the jobsMutex and jobs fields can be extracted to a type that ensures concurrency safe operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make humio_exporter more resilient, I've made some changes, so it doesn't crash on all 404 or 5xx responses.
Part of ESA-1044