sonar: Update deprecated action #20
Conversation
|
Warning Rate limit exceeded@echarrod has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 39 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe GitHub Actions workflow for Sonar report uploads was updated. The action used for scanning was changed from Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/sonar.yaml (1)
31-31: Add a newline at end‑of‑file
YAML files should end with a newline to satisfy linters (e.g.,new-line-at-end-of-file) and POSIX conventions.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 31-31: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/sonar.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/sonar.yaml
[error] 31-31: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.github/workflows/sonar.yaml (3)
29-29: Securely inject SONAR_TOKEN from GitHub secrets
Usingsecrets.SONAR_TOKENto populate theSONAR_TOKENenvironment variable is the correct approach to keep the token secure and scoped to this step.
30-30: Conditional execution for same-repo PRs or valid token
Theifexpression (github.event.pull_request.head.repo.full_name == github.repository || env.SONAR_TOKEN != '') correctly restricts the scan to trusted contexts, preventing token leaks on external forks.
31-31: Update to the recommended SonarQube scan action
Replacing the deprecatedsonarsource/sonarcloud-github-action@masterwithSonarSource/[email protected]aligns with the official recommendation and should be fully compatible as a drop‑in replacement.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 31-31: no new line character at the end of file
(new-line-at-end-of-file)
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
Not needed, updated separately - https://github.com/luno/depgraph/blob/main/.github/workflows/sonar.yml |
This PR replaces the deprecated
sonarsource/sonarcloud-github-action@masterwith the recommendedSonarSource/sonarqube-scan-action@masteras suggested in the CI warning message.The warning message was:
This change follows the same pattern as used in luno-go, including the conditional check to only run the SonarQube scan when:
Summary by CodeRabbit