-
Notifications
You must be signed in to change notification settings - Fork 1
sonar: Update deprecated action #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe GitHub Actions workflow for Sonar report uploads was updated. The action used for scanning was changed from Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/sonar.yaml (1)
31-31
: Add a newline at end‑of‑file
YAML files should end with a newline to satisfy linters (e.g.,new-line-at-end-of-file
) and POSIX conventions.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 31-31: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/sonar.yaml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/sonar.yaml
[error] 31-31: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.github/workflows/sonar.yaml (3)
29-29
: Securely inject SONAR_TOKEN from GitHub secrets
Usingsecrets.SONAR_TOKEN
to populate theSONAR_TOKEN
environment variable is the correct approach to keep the token secure and scoped to this step.
30-30
: Conditional execution for same-repo PRs or valid token
Theif
expression (github.event.pull_request.head.repo.full_name == github.repository || env.SONAR_TOKEN != ''
) correctly restricts the scan to trusted contexts, preventing token leaks on external forks.
31-31
: Update to the recommended SonarQube scan action
Replacing the deprecatedsonarsource/sonarcloud-github-action@master
withSonarSource/[email protected]
aligns with the official recommendation and should be fully compatible as a drop‑in replacement.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 31-31: no new line character at the end of file
(new-line-at-end-of-file)
This PR replaces the deprecated
sonarsource/sonarcloud-github-action@master
with the recommendedSonarSource/sonarqube-scan-action@master
as suggested in the CI warning message.The warning message was:
This change follows the same pattern as used in luno-go, including the conditional check to only run the SonarQube scan when:
Summary by CodeRabbit