streaming: Remove logging pair and key on failure #145
Conversation
| @@ -151,8 +151,7 @@ func (c *Conn) manageForever() { | |||
|
|
|||
| for { | |||
| if err := c.connect(); err != nil { | |||
| log.Printf("luno/streaming: Connection error key=%s pair=%s: %v", | |||
| c.keyID, c.pair, err) | |||
| log.Printf("luno/streaming: Connection error: %v", err) | |||
There was a problem hiding this comment.
log/slog is available (maybe not for the version we support for luno-go so you can log parameters.
There was a problem hiding this comment.
I think using slog will defeat the purpose of this change.
There was a problem hiding this comment.
Is the purpose only be able to collect all logs through searching "luno/streaming: Connection error:" on something like Kibana or is it to consolidate metrics?
There was a problem hiding this comment.
Was going to say we can keep pair, but don't know if it's that useful for this error? 🤔
There was a problem hiding this comment.
The purpose is to collate the logs. The pair and key is not particularly useful.
| @@ -151,8 +151,7 @@ func (c *Conn) manageForever() { | |||
|
|
|||
| for { | |||
| if err := c.connect(); err != nil { | |||
| log.Printf("luno/streaming: Connection error key=%s pair=%s: %v", | |||
| c.keyID, c.pair, err) | |||
| log.Printf("luno/streaming: Connection error: %v", err) | |||
There was a problem hiding this comment.
Was going to say we can keep pair, but don't know if it's that useful for this error? 🤔
|
@ptrenwith is this still needed? |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
streaming/streaming.go:154
- Removing key and pair information might reduce diagnostic detail; please confirm that the consolidated log message still provides sufficient context for troubleshooting connection errors.
log.Printf("luno/streaming: Connection error: %v", err)
Consolidate logging.