CI: Don't treat phpdoc types as certain for phpstan #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a phpstan error about the instanceof check for AnalyticsDetailLevels to always be true. We can't know this in the code, because they are stored in an array, and it's conceivable that wrong values could enter here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/0.12.x #10 +/- ##
==================================================
Coverage ? 100.00%
Complexity ? 64
==================================================
Files ? 1
Lines ? 204
Branches ? 0
==================================================
Hits ? 204
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcella-galambos-move
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a phpstan error about the instanceof check for AnalyticsDetailLevels to always be true. We can't know this in the code, because they are stored in an array, and it's conceivable that wrong values could enter here.