General: Add phpstan array shapes #35
Conversation
| * @phpstan-type Endpoint array{ | ||
| * platform: string, | ||
| * payloadType: string, | ||
| * endpoint: string, | ||
| * message_id?: string|null, | ||
| * } |
There was a problem hiding this comment.
I don't think it's this easy. This breaks the current pass-through use-case, where any additional fields coming in are also going out.
There was a problem hiding this comment.
Do you mean it should be more generic? That for example there could be more fields in the array?
There was a problem hiding this comment.
I just had a revelation that we can intersect array types, I changed that here
There was a problem hiding this comment.
This doesn't seem to be documented yet, but I think this would be preferred over an intersection: https://github.com/phpstan/phpdoc-parser/pull/250/files
The main problem is the "in = out" part though. So, typing that the output of one method is equals to the input of another. That just might be too hard to statically do though.
The alternative is to make this a strict shape somehow, and break all current flows that allow extra fields in there.
brianstoop
force-pushed
the
phpstan/shapes/general
branch
from
6a648f6 to
009f633
Compare
|
marcella-galambos-move
force-pushed
the
phpstan/shapes/general
branch
from
009f633 to
100f164
Compare
|
2 participants
Depends on #36 for the typos fix