Skip to content

Conversation

@brianstoop
Copy link
Contributor

Depends on #36 for typos fix

@brianstoop brianstoop marked this pull request as ready for review March 12, 2025 15:17
@pprkut pprkut force-pushed the phpstan/shapes/jpush branch from 1a45fd3 to 46d8968 Compare April 29, 2025 10:55
@sonarqubecloud
Copy link

Copy link
Contributor

@pprkut pprkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Payload structure is too simple and should match the upstream documentation, just like FCM.

See here (in Chinese): https://docs.jiguang.cn/jpush/server/push/rest_api_v3_push

* JPush Message Payload Generator.
*
* @phpstan-type JPushMessagePayloadElements array{
* platform: string[],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform is something like "all"|array<"android","ios","quickapp","hmos">

*
* @phpstan-type JPushMessagePayloadElements array{
* platform: string[],
* audience: array<string, mixed>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all" or array{"tag":?string[], "tag_and"?:string[], "tag_not"?:string[], "alias"?:string[], "registration_id"?:string[], "segment"?:string[], "abtest"?:string[]} or array{"live_activity_id":string}

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants