APNS: Add phpstan array shapes #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pprkut
requested changes
Mar 12, 2025
Comment on lines
+20
to
+27
| * | ||
| * @phpstan-type APNSError array{ | ||
| * MESSAGE: Message, | ||
| * ERRORS: array{ | ||
| * statusCode: int, | ||
| * statusMessage: string, | ||
| * }[], | ||
| * } |
Contributor
There was a problem hiding this comment.
This should reuse the types from ApnsPHP (that's why I added them there)
Contributor
Author
There was a problem hiding this comment.
Ahh, I didn't see them because we use a tag that does not have the types yet. Can I point to the ApnsPHP release branch instead?
Contributor
There was a problem hiding this comment.
Yeah, that's fine. We can switch back to a tag on the next release
marcella-galambos-move
force-pushed
the
phpstan/shapes/apns
branch
from
7076210 to
5a12da0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #36 for typos fix