Skip to content

Conversation

@reza-ygb
Copy link

@reza-ygb reza-ygb commented Sep 22, 2025

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Summary by Sourcery

Add DNS Interceptor entry to the README OSS list and introduce a GitHub Actions workflow to generate SLSA provenance at level 3 using the SLSA Framework

CI:

  • Add SLSA generic generator workflow to produce provenance subjects and upload artifacts on release

Documentation:

  • Include DNS Interceptor project in the README list of open-source software

Added DNS Interceptor project to the list of open-source software.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 22, 2025

Reviewer's Guide

Introduce a new DNS Interceptor entry in the project README and add a GitHub Actions workflow to generate SLSA 3 provenance for releases.

File-Level Changes

Change Details Files
Add DNS Interceptor to the curated OSS list
  • Insert DNS Interceptor project link, name, and description
  • Ensure bullet formatting and spacing consistency
README.md
Introduce SLSA generic generator GitHub Actions workflow
  • Create workflow file under .github/workflows
  • Configure a build job that produces artifacts and computes SHA256 hashes
  • Integrate slsa-framework SLSA 3 provenance generation and upload assets
.github/workflows/generator-generic-ossf-slsa3-publish.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The generic SLSA workflow is using placeholder artifact steps (echoing artifact1 and artifact2) – please update the Build artifacts step and hash generation to reflect your actual build outputs and file names for accurate provenance.
  • In the README, consider organizing the new DNS Interceptor entry under the most relevant category or creating a dedicated section to keep the list structure consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The generic SLSA workflow is using placeholder artifact steps (echoing artifact1 and artifact2) – please update the Build artifacts step and hash generation to reflect your actual build outputs and file names for accurate provenance.
- In the README, consider organizing the new DNS Interceptor entry under the most relevant category or creating a dedicated section to keep the list structure consistent.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant