-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Reza ygb patch 1 #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reza-ygb
wants to merge
2
commits into
luong-komorebi:master
Choose a base branch
from
reza-ygb:reza-ygb-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reza ygb patch 1 #893
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added DNS Interceptor project to the list of open-source software.
Reviewer's GuideIntroduce a new DNS Interceptor entry in the project README and add a GitHub Actions workflow to generate SLSA 3 provenance for releases. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The generic SLSA workflow is using placeholder artifact steps (echoing artifact1 and artifact2) – please update the Build artifacts step and hash generation to reflect your actual build outputs and file names for accurate provenance.
- In the README, consider organizing the new DNS Interceptor entry under the most relevant category or creating a dedicated section to keep the list structure consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The generic SLSA workflow is using placeholder artifact steps (echoing artifact1 and artifact2) – please update the Build artifacts step and hash generation to reflect your actual build outputs and file names for accurate provenance.
- In the README, consider organizing the new DNS Interceptor entry under the most relevant category or creating a dedicated section to keep the list structure consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context
Summary by Sourcery
Add DNS Interceptor entry to the README OSS list and introduce a GitHub Actions workflow to generate SLSA provenance at level 3 using the SLSA Framework
CI:
Documentation: