Keep deferred copy count storage alive#156
Merged
Merged
Conversation
4589b84 to
2907b05
Compare
2907b05 to
4350a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
rpc_write() stores iovec pointers and flushes them later in rpc_write_end(). lupine_write_pending_dtoh_copies() queued a pointer to its local count variable, so calls made before rpc_write_end() could reuse that stack slot. In vectorAdd_nvrtc, the client read garbage for copy_count and then waited for nonexistent copy payload bytes.
Verification