-
Notifications
You must be signed in to change notification settings - Fork 32
✨ add Windows support #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e2f6953
8465a5f
0e9d42d
c69e12a
fb23d9c
6bf55ba
92c69e4
f5ad52c
06025ea
271bbf4
1d2cc25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1089,7 +1089,8 @@ impl GitRepository<'_> { | |
| .env("GIT_COMMITTER_EMAIL", "[email protected]") | ||
| .env("GIT_COMMITTER_DATE", datetime_str) | ||
| .env("GIT_CONFIG_NOSYSTEM", "true") | ||
| .env("HOME", "/dev/null") | ||
| .env("GIT_CONFIG_GLOBAL", "/dev/null") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems unrelated to the actual PR, no?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I remember correctly, the tests doesn't pass until you change that line. I suppose is because windows doesn't have a |
||
| // .env("HOME", "/dev/null") | ||
| .output() | ||
| .unwrap_or_else(|_| panic!("failed to execute git {}", args.join(" "))); | ||
| println!("git {}: returned {}", args.join(" "), out.status,); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't you also need to remove the xdg crate from the manifest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, seems correct