Skip to content

🔀 Update forms example to be compatible with latest formal API changes#363

Merged
hayleigh-dot-dev merged 3 commits intolustre-labs:mainfrom
jcorentin:update_forms_example
Aug 7, 2025
Merged

🔀 Update forms example to be compatible with latest formal API changes#363
hayleigh-dot-dev merged 3 commits intolustre-labs:mainfrom
jcorentin:update_forms_example

Conversation

@jcorentin
Copy link
Contributor

Hi!
formal 3.0.0 got released with API breaking changes.
I updated the relevant example file to be compatible with this new version.

Another option would be to copy formal’s own up to date lustre example from here, so that it is easy to keep it in sync in the future.

Copy link
Collaborator

@hayleigh-dot-dev hayleigh-dot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for this! I've left some minor comments but mostly looks good to me 💕

@jcorentin
Copy link
Contributor Author

Hi Hayleigh,
I updated the PR based on your comments.

@hayleigh-dot-dev
Copy link
Collaborator

Thank you!

@hayleigh-dot-dev hayleigh-dot-dev merged commit 2ee6500 into lustre-labs:main Aug 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants