Add MathML Core elements#399
Conversation
|
Never make a pull request without sleeping on it first. 😂 I believe a lot of these elements are only intended to have text nodes as children, not any arbitrary element. I'm going to look through more closely now and determine which functions could take a string as their second argument, rather than having users write |
|
I'm well overdue to follow up here, but I believe it is in fact ready to merge. Should I git squash first? |
|
I squash all PRs anyway, no need to worry about that ^.^ |
|
I'll do a quick check in the morning to make sure all the elements that take children make sense but otherwise looks good to me! thanks for adding this. |
src/lustre/element/mathml.gleam
Outdated
| // MATHML ELEMENTS: GROUPING --------------------------------------------------- | ||
|
|
||
| /// | ||
| pub fn maction( |
There was a problem hiding this comment.
It looks like according to mdn this element is deprecated. Let's remove it so folks don't use it.
There was a problem hiding this comment.
I missed that because I was only referencing the W3C technical report. Oops!
I've removed it.
There was a problem hiding this comment.
Easy miss, the note on the technical report says that UAs only implementing MathML Core can ignore this in favour of javascript etc which everyone but safarai (interestingly) does.
3 participants
I've tried my best to match the style of the rest of the codebase, but feel free to make any changes!