Fixed a bug where server-rendered HTML from sources other than Lustre would virtualise incorrectly.#446
Merged
Merged
Conversation
there are multiple. fix #445 this additionally handles cases where there are elements in the tree that we don't virtualise, like additional comments
yoshi-monster
force-pushed
the
hayleigh/445
branch
from
9846531 to
afca5ec
Compare
Contributor
|
rebased and handled the case we spoke about :) |
yoshi-monster
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were making too-strong assumptions about the source of existing HTML when virtualising the DOM. This was problematic when the element being mounted contained multiple children but not fragment comment markers: instead of removing or handling the multiple children, they were ignored and left in the DOM.
This scenario could come up in two ways:
To address this we now always virtualise multiple children at the root as a fragment. If the expected fragment comment markers are not present, they are added directly to the DOM before virtualisation to avoid special-casing how fragments are virtualised.