Skip to content

Skip passing normalization if it is not active in the config#377

Merged
dtronmans merged 3 commits intomainfrom
fix/normalization-during-export
Apr 24, 2026
Merged

Skip passing normalization if it is not active in the config#377
dtronmans merged 3 commits intomainfrom
fix/normalization-during-export

Conversation

@dtronmans
Copy link
Copy Markdown
Contributor

Purpose

Resulting ONNX config:
resulting_output_onnx

Resulting RVC4 config:
resulting_output_rvc4

None for mean and scale is properly handled in modelconverter:

Another option would be to manually pass the identity (so [0, 0, 0] [1, 1, 1] for RGB and [0] [1] for grayscale) to the ONNX archive if normalization is not active, instead of passing None and letting it be handled downstream by modelconverter

Specification

Dependencies & Potential Impact

Deployment Plan

Testing & Validation

@dtronmans dtronmans requested a review from a team as a code owner April 24, 2026 07:57
@dtronmans dtronmans requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team April 24, 2026 07:57
@github-actions github-actions Bot added the fix Fixing a bug label Apr 24, 2026
Copy link
Copy Markdown
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And yes, I think is fine to have null values and let other tools (modelconverter) handle this correctly since we do allow None values for this parameters in the schema.

@dtronmans dtronmans merged commit fd22248 into main Apr 24, 2026
11 checks passed
@dtronmans dtronmans deleted the fix/normalization-during-export branch April 24, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants