Skip passing normalization if it is not active in the config#377
Merged
Skip passing normalization if it is not active in the config#377
Conversation
klemen1999
approved these changes
Apr 24, 2026
Collaborator
klemen1999
left a comment
There was a problem hiding this comment.
LGTM. And yes, I think is fine to have null values and let other tools (modelconverter) handle this correctly since we do allow None values for this parameters in the schema.
kozlov721
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resulting ONNX config:

Resulting RVC4 config:

Nonefor mean and scale is properly handled inmodelconverter:Another option would be to manually pass the identity (so [0, 0, 0] [1, 1, 1] for RGB and [0] [1] for grayscale) to the ONNX archive if normalization is not active, instead of passing
Noneand letting it be handled downstream bymodelconverterSpecification
Dependencies & Potential Impact
Deployment Plan
Testing & Validation