Skip to content

Fix esp32 build #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Fix esp32 build #156

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e08dbb1
Fixes build script for ESP32
MitchBradley Oct 20, 2024
7efcaa9
Update macOS.py
MitchBradley Oct 20, 2024
361355e
Update raspberry_pi.py
MitchBradley Oct 20, 2024
3808ea9
Update unix.py
MitchBradley Oct 20, 2024
7a532e8
Update esp32.py
MitchBradley Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions builder/esp32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from . import (
read_file,
write_file,
copy_updated_files,
copy_micropy_updates,
revert_files,
scrub_build_folder
)
Expand Down Expand Up @@ -125,7 +125,7 @@ def save(self):
)

if not os.path.exists(f'{SCRIPT_DIR}/build'):
os.mkdir(f'{SCRIPT_DIR}/build')
os.makedirs(f'{SCRIPT_DIR}/build')
Copy link
Collaborator

@kdschlosser kdschlosser Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to be changed because SCRIPT_DIR is where the make.py script is located. If that directory doesn't exist then there is a really HUGE problem. mkdir will create a single directory so long as all other directories under it exist. So in this case every other directory under the build directory MUST exist because they ran the make.py script

Copy link
Contributor Author

@MitchBradley MitchBradley Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed that by 7a532e8 . I didn't mean to change that SCRIPT_DIR line, but rather another line elsewhere in the file.


with open(self.save_file_path, 'w') as f:
f.write(PARTITION_HEADER)
Expand Down Expand Up @@ -1140,7 +1140,7 @@ def compile(*args): # NOQA
update_mpconfigboard()
update_mpconfigport()

copy_updated_files('esp32')
copy_micropy_updates('esp32')

try:
cmd_ = compile_cmd[:]
Expand Down