-
Notifications
You must be signed in to change notification settings - Fork 224
build: use .defaults as a way to configure lvgl instead of lv_conf.h #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="CMakeLists.txt">
<violation number="1" location="CMakeLists.txt:29">
LV_CONF_DEFAULTS_PATH points to lv_conf_3d.defaults, but that file is absent from the repo, so configure_file will fail and the build cannot proceed.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
CMakeLists.txt
Outdated
CACHE PATH "path to lv_conf.h" FORCE) | ||
|
||
set(LVGL_TEMPLATE_PATH "${CMAKE_SOURCE_DIR}/lvgl/lv_conf_template.h") | ||
set(LV_CONF_DEFAULTS_PATH "${CMAKE_SOURCE_DIR}/lv_conf_3d.defaults") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LV_CONF_DEFAULTS_PATH points to lv_conf_3d.defaults, but that file is absent from the repo, so configure_file will fail and the build cannot proceed.
Prompt for AI agents
Address the following comment on CMakeLists.txt at line 29:
<comment>LV_CONF_DEFAULTS_PATH points to lv_conf_3d.defaults, but that file is absent from the repo, so configure_file will fail and the build cannot proceed.</comment>
<file context>
@@ -21,6 +21,36 @@ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wpedantic")
+ CACHE PATH "path to lv_conf.h" FORCE)
+
+set(LVGL_TEMPLATE_PATH "${CMAKE_SOURCE_DIR}/lvgl/lv_conf_template.h")
+set(LV_CONF_DEFAULTS_PATH "${CMAKE_SOURCE_DIR}/lv_conf_3d.defaults")
+set(GENERATE_SCRIPT_PATH "${CMAKE_SOURCE_DIR}/lvgl/scripts/generate_lv_conf.py")
+
</file context>
set(LV_CONF_DEFAULTS_PATH "${CMAKE_SOURCE_DIR}/lv_conf_3d.defaults") | |
set(LV_CONF_DEFAULTS_PATH "${CMAKE_SOURCE_DIR}/lv_conf.defaults") |
✅ Addressed in 0154606
dffc16e
to
36858f2
Compare
36858f2
to
17665ea
Compare
This is a proposal to not use
lv_conf.h
in this repository and instead uselv_conf.defaults
lv_conf.h
is generated at build time using Cmake fromlv_conf.defaults
Summary by cubic
Generate lv_conf.h at build time from lv_conf.defaults via CMake to simplify LVGL configuration and remove the tracked header. This reduces config drift and makes per-build tweaks easier.
Refactors
Migration