Merged
Conversation
Member
|
@AndreCostaaa Also: is it Yocto? If so we need to tell it in the README. |
Collaborator
|
It is yocto based but ST provides a default ready to install image and SDK, no need to build it |
Co-authored-by: André Costa <andre_miguel_costa@hotmail.com>
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="boards/stm32mp157f-dk/README.md">
<violation number="1" location="boards/stm32mp157f-dk/README.md:132">
P2: Wayland SSH run instructions omit required session environment variables, which can cause `lvglsim` to fail to connect to the compositor.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ``` | ||
| On the board, run the binary: | ||
| ```shell | ||
| ./lvglsim -m |
There was a problem hiding this comment.
P2: Wayland SSH run instructions omit required session environment variables, which can cause lvglsim to fail to connect to the compositor.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/stm32mp157f-dk/README.md, line 132:
<comment>Wayland SSH run instructions omit required session environment variables, which can cause `lvglsim` to fail to connect to the compositor.</comment>
<file context>
@@ -0,0 +1,173 @@
+```
+On the board, run the binary:
+```shell
+./lvglsim -m
+```
+
</file context>
Suggested change
| ./lvglsim -m | |
| XDG_RUNTIME_DIR=/run/user/1000 WAYLAND_DISPLAY=wayland-1 ./lvglsim -m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds STM32MP157F-DK2 board support for lv_port_linux. Includes setup for Wayland, SDL, and DRM backends, build/run instructions, and Project Creator metadata so users can run LVGL on ST’s MP1 devkit.
Written for commit 427916a. Summary will update on new commits.