Conversation
without the need to recompile each time
kisvegabor
left a comment
There was a problem hiding this comment.
Thank you!
I made a quick review, mainly to find formatting and naming issues.
1898081 to
4e3ad17
Compare
|
@kisvegabor I've adjusted the code. |
|
For the failing CI see this : #74 |
|
Parsing lv_conf.h for cmake could be a hassle. What if instead you made lv_conf.h.in and wrote out the desired values based on inputs to the initial cmake setup command? -DUSE_WAYLAND for instance. Edited. Nevermind. I see EDGEMTech ran into the same thing I did with scripts/backend_conf not being run in the correct place. They fixed it by forcing the path in the script. I posted over in #57 (comment) that the ideal fix is passing in WORKING_DIRECTORY to execute_process. This same idea could be replicated. Read out the value and update the CMake logic. I thought this could get ugly because I was thinking of running a compiled program with #ifdefs from the header. |
|
Avoid allocating lists of string, but instead move the functions to check if a backend exists and print supported backends to driver_backends.c
|
@shaleh Ok thanks for suggestion |
Split backends into separate files, adding the capability of linking to multiple backends at once and select which one to use at runtime. This also avoids EXCESSIVE conditional compilation soup in main.c - it is irritating for a tool that I use daily.
The next step is to find a clean way of configuring CMAKE or GNU make based on the options found
in lv_conf.h