Task/update for editor v1.2.0#367
Conversation
because now we have bundled runtimes
There was a problem hiding this comment.
No issues found across 151 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 151 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="examples/components/basic/roller/roller_gen.h">
<violation number="1" location="examples/components/basic/roller/roller_gen.h:24">
P2: Use `#if LV_USE_XML` here instead of `#ifdef`; the default config defines `LV_USE_XML` to 0, so this currently includes the XML header even when XML support is disabled.</violation>
</file>
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
| #include "lvgl/lvgl_private.h" | ||
| #endif | ||
|
|
||
| #ifdef LV_USE_XML |
There was a problem hiding this comment.
P2: Use #if LV_USE_XML here instead of #ifdef; the default config defines LV_USE_XML to 0, so this currently includes the XML header even when XML support is disabled.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At examples/components/basic/roller/roller_gen.h, line 24:
<comment>Use `#if LV_USE_XML` here instead of `#ifdef`; the default config defines `LV_USE_XML` to 0, so this currently includes the XML header even when XML support is disabled.</comment>
<file context>
@@ -15,10 +15,14 @@ extern "C" {
+ #include "lvgl/lvgl_private.h"
+#endif
+
+#ifdef LV_USE_XML
+ #include "lv_xml/lv_xml.h"
#endif
</file context>
| #ifdef LV_USE_XML | |
| #if LV_USE_XML |
No description provided.