Skip to content

Task/update for editor v1.2.0#367

Merged
mrhubbs merged 2 commits into
masterfrom
task/update-for-editor-v1.2.0
May 16, 2026
Merged

Task/update for editor v1.2.0#367
mrhubbs merged 2 commits into
masterfrom
task/update-for-editor-v1.2.0

Conversation

@mrhubbs
Copy link
Copy Markdown
Collaborator

@mrhubbs mrhubbs commented May 16, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 151 files

Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic

@mrhubbs mrhubbs marked this pull request as draft May 16, 2026 05:34
@mrhubbs mrhubbs marked this pull request as ready for review May 16, 2026 05:44
@mrhubbs mrhubbs merged commit 6c75bb9 into master May 16, 2026
1 of 2 checks passed
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 151 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="examples/components/basic/roller/roller_gen.h">

<violation number="1" location="examples/components/basic/roller/roller_gen.h:24">
P2: Use `#if LV_USE_XML` here instead of `#ifdef`; the default config defines `LV_USE_XML` to 0, so this currently includes the XML header even when XML support is disabled.</violation>
</file>

Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic

#include "lvgl/lvgl_private.h"
#endif

#ifdef LV_USE_XML
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Use #if LV_USE_XML here instead of #ifdef; the default config defines LV_USE_XML to 0, so this currently includes the XML header even when XML support is disabled.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At examples/components/basic/roller/roller_gen.h, line 24:

<comment>Use `#if LV_USE_XML` here instead of `#ifdef`; the default config defines `LV_USE_XML` to 0, so this currently includes the XML header even when XML support is disabled.</comment>

<file context>
@@ -15,10 +15,14 @@ extern "C" {
+    #include "lvgl/lvgl_private.h"
+#endif
+
+#ifdef LV_USE_XML
+    #include "lv_xml/lv_xml.h"
 #endif
</file context>
Suggested change
#ifdef LV_USE_XML
#if LV_USE_XML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant