feat: support websocket #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, thanks.. Will take a look. |
|
Hi, I had a quick look.. have you tested this implementation via a web proxy? When I originally looked into this issue many years ago i seem to remember that, to support web proxies it must be implemented via HTTP connect as i noted here. I'm happy to be proved wrong regarding HTTP CONNECT, so long as proxies are supported. A big chuck of the lws usage comes from the workplace, where most office networks sit behind an enterprise web proxy controlling and policing all web traffic. If we fail to support proxies, it will break for many users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will handle websocket for rewrite module
It support both http/https/ws/wss
close #7, lwsjs/local-web-server#126