Machinery to sync images to images.linuxcontainers.org/capn/ #187
+260
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angelos Kolaitis <[email protected]>
Signed-off-by: Angelos Kolaitis <[email protected]>
Signed-off-by: Angelos Kolaitis <[email protected]>
Signed-off-by: Angelos Kolaitis <[email protected]>
Signed-off-by: Angelos Kolaitis <[email protected]>
Member
|
There's something pretty wrong with this tool. It runs the system out of memory... See multi-GB RSS: |
stgraber
reviewed
Dec 25, 2025
Comment on lines
+64
to
+66
| if _, err := io.Copy(f, resp.Body); err != nil { | ||
| return fmt.Errorf("failed to download image: %w", err) | ||
| } |
Member
There was a problem hiding this comment.
This should be a for loop doing copy in chunk of 1-4MB to avoid elevated memory usage.
Something like this: https://github.com/lxc/incus-os/blob/main/incus-osd/internal/providers/utils.go#L64
Member
|
|
Member
|
Our image publisher is an Incus container with 4GB of RAM, so Go I/Os really need to be correctly chunked to avoid the process getting killed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #180
Changes
simplestreams synccommand that implements the sync mechanismhack/infra/images.yamlfile, currently needs to be statically updated to add new imagesNotes
To sync images from GitHub actions into a simplestreams index directory at
$DIR: