Remove cloud provider node patch logic, remove BootstrapSucceeded condition from LXCMachine
#64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the BootstrapSucceeded condition from API - Remove the internal/cloudinit package - Remove the incus.GetCloudInitStatus() helper Signed-off-by: Angelos Kolaitis <[email protected]>
- Do not set providerID from the provider side - Mark lxcCluster.spec.skipCloudProviderNodePatch as deprecated in API - Drop internal/cloudprovider package - Set provider-id as kubelet extra args instead Signed-off-by: Angelos Kolaitis <[email protected]>
…y more Signed-off-by: Angelos Kolaitis <[email protected]>
Signed-off-by: Angelos Kolaitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spec.providerIDin the provider code, this is now configured as part of the cluster template through theprovider-id: "{{ v1.local_hostname }}"extra kubelet argBootstrapSucceededcondition, as it is not required as part of the Infrastructure Provider contract.InstanceProvisionedandReadyconditions are enoughChanges
lxcCluster.spec.skipCloudProviderNodePatchfield as deprecatedNotes
An important behavior change as part of this PR is that the provider no longer requires an active Incus agent running on VM instances (not important for containers. This also helps address some of the flakiness of the
QuickStart KVMe2e tests in our CI environment