Enforce GPG verification across multiple distros (Fixes #963) #964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes and enforces GPG verification requirements across multiple supported distributions. The primary change is the introduction of a
validateGPGRequirementshelper incommon.go, which implements the following logic requested in #963:keysare defined in the source definition, verification is always enforced, regardless of the protocol.This logic has been applied to
almalinux,alpine,archlinux,centos,funtoo,gentoo,rocky,ubuntu, andvoidlinuxsources.Specific security fixes included:
CHECKSUMfile was downloaded but not verified against its signature.validateGPGRequirements, ensuring GPG checks are enforced unless explicitly skipped.Unit tests for
validateGPGRequirementshave been added incommon_test.go.Fixes #963
Verification
skip_verificationsetting.skip_verificationequals false — Build proceeds with a warning about missing GPG verification.