Open
Conversation
…truct Signed-off-by: Mathias Gibbens <mathias.gibbens@futurfusion.io>
…if ConfirmationTimeout is defined Signed-off-by: Mathias Gibbens <mathias.gibbens@futurfusion.io>
Signed-off-by: Mathias Gibbens <mathias.gibbens@futurfusion.io>
Signed-off-by: Mathias Gibbens <mathias.gibbens@futurfusion.io>
gibmat
force-pushed
the
network-config-rollback
branch
from
d23a559 to
9be4610
Compare
Signed-off-by: Mathias Gibbens <mathias.gibbens@futurfusion.io>
Signed-off-by: Mathias Gibbens <mathias.gibbens@futurfusion.io>
Signed-off-by: Mathias Gibbens <mathias.gibbens@futurfusion.io>
gibmat
force-pushed
the
network-config-rollback
branch
from
9be4610 to
fe75831
Compare
stgraber
reviewed
Mar 18, 2026
Comment on lines
+166
to
+175
| for time.Since(startTime) < confirmationTimeout { | ||
| // If NetworkConfigurationPending is false, that means the user has confirmed | ||
| // the changes, so there's no need to restore the prior network configuration. | ||
| if !s.state.NetworkConfigurationPending { | ||
| return | ||
| } | ||
|
|
||
| // Sleep five seconds before checking again. | ||
| time.Sleep(5 * time.Second) | ||
| } |
Member
There was a problem hiding this comment.
That's a bit racy though, I could:
- Perform a config change with a revert set to 5min
- Confirm it
- Within 5s, send another config change with a revert set to 5min
- Have the go routine of the previous change kick in and revert to the old-old-config
- Have the go routine handling the second change then exit thinking the user confirmed the change
It's not super likely to happen, you'd need someone who's making two consecutive very small edits, but it may be possible when tweaking something like VLANs.
Using a channel for confirmation would allow for using a select statement waiting on either user confirmation OR a timeout, eliminating the need for the sleep 5s loop and the race condition in the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #860