Simplify config subvolume naming by using static "instance" prefix#3050
Merged
Simplify config subvolume naming by using static "instance" prefix#3050
Conversation
presztak
force-pushed
the
fix_btrfs_subvolume_names
branch
2 times, most recently
from
5dcef3f to
1823cbc
Compare
stgraber
reviewed
Mar 19, 2026
Member
|
Looks good overall, just need to make the patch be non-fatal on conversion failure to avoid potentially deadlocking upgrades when a machine has some VMs with corrupted config volumes. |
Member
|
Those can be fixed later using the instance repair API which will re-build the volume using the new layout. |
presztak
force-pushed
the
fix_btrfs_subvolume_names
branch
3 times, most recently
from
b3ed1d0 to
d93dca0
Compare
This is no longer needed because the config subvolume name no longer includes the instance name, but uses the 'instance-' prefix instead. Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
…prefix Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
…-name>-' to 'instance-' Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
presztak
force-pushed
the
fix_btrfs_subvolume_names
branch
from
d93dca0 to
7cc4249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the naming scheme for Btrfs subvolumes used as VM config volumes.
Previously, subvolumes were named using the instance name:
<instance-name><instance-name>-snap0This PR replaces that with a static naming scheme:
instanceinstance-snap0By removing the dependency on the instance name, this simplifies a number of operations.
In particular, renaming an instance no longer requires renaming associated Btrfs subvolumes,
which reduces complexity and avoids unnecessary filesystem operations.