Support including additional GPU functions on different IOMMU groups - #3478
Draft
masnax wants to merge 5 commits into
Draft
Support including additional GPU functions on different IOMMU groups#3478masnax wants to merge 5 commits into
masnax wants to merge 5 commits into
Conversation
…mu_group loop Signed-off-by: Max Asnaashari <max.asna@futurfusion.io>
…her iommu groups Signed-off-by: Max Asnaashari <max.asna@futurfusion.io>
Signed-off-by: Max Asnaashari <max.asna@futurfusion.io>
Signed-off-by: Max Asnaashari <max.asna@futurfusion.io>
Signed-off-by: Max Asnaashari <max.asna@futurfusion.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incus' current behaviour with the
gpudevice type is to auto-load all additional GPU functions in the same IOMMU group.If GPU functions are on different IOMMU groups, then they are not imported, and adding them as explicit
pcidevices causes Incus to import them as discrete PCI devices on separate root ports, which then has to be amended withraw.qemu.conforraw.qemu.scriptlet.Here, I've added a
functionsconfig key that accepts comma delimited additional function numbers (1-7) to enforce inclusion as long as the following path exists on the main device:So to include all of these, the devices section would look like this:
With the changes here, additional functions are enforced as a fallback to the existing IOMMU group inclusions.
Some additional steps are required before this can be considered ready:
functionskey, so it can apply to non-GPU devices too. This could look like explicitpciandgpudevices, where Incus internally determines if they ought to be treated as the same multifunction device.