Port more Jenkins tests to Github Actions (VM) - #3814
Open
stgraber wants to merge 19 commits into
Open
Conversation
stgraber
force-pushed
the
tests
branch
3 times, most recently
from
August 11, 2026 04:43
8e3893b to
ae429bc
Compare
bensmrs
approved these changes
Aug 11, 2026
bensmrs
left a comment
bensmrs
left a comment
Contributor
There was a problem hiding this comment.
2 nits that repeat throughout the PR
stgraber
force-pushed
the
tests
branch
24 times, most recently
from
August 12, 2026 02:42
82baea3 to
a490de7
Compare
This uses our warning filter to silence expected double-close, effectively all code paths that have an existing close in the success path. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
This moves some logic around so the close logic works the same way in all cases. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
When the last server in a cluster shuts down, it can get stuck due to a pile up of pending events being stuck on a lock held by a sender trying to access the database, in turn holding up daemon shutdown. It's always a bit of a messy situation when shutting down without a functional database so this really is just to allow things to keep moving forward and not be stuck behind a lock. The events themselves will still fail to send and the DB transactions will still be stuck in retry, but that doesn't matter as the process is about to exit. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Pull a recent go-cowsql panic fix. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
DRBD fails to bring up volumes smaller than 4MiB, round up small volumes such as ISO imports. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
The backing storage rounds volumes up, causing published images to be slightly larger than the volume size they came from and so unusable with the same size setting. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Newer LVM fails to resize snapshots already at full CoW capacity, breaking snapshot restore on non-thinpool pools. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Entries were written in random map order, breaking anything parsing qemu.conf and making restarts harder to compare. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Already covered by the standalone_storage suite runs. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Some operations like whole VM exports can take more than the default two minutes on slower systems. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Ported from lxc-ci's bin/test-incus-cpu-vm. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Ported from lxc-ci's bin/test-incus-guestapi-vm. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Ported from lxc-ci's bin/test-incus-network-routed. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Ported from lxc-ci's bin/test-incus-storage-disks-vm. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Ported from lxc-ci's bin/test-incus-storage-vm. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Ported from lxc-ci's bin/test-incus-storage-volumes-vm. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Runs on self-hosted amd64 runners with nested virtualization support. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
bensmrs
approved these changes
Aug 12, 2026
bensmrs
left a comment
bensmrs
left a comment
Contributor
There was a problem hiding this comment.
Just one nit on copy but otherwise LGTM
Comment on lines
+171
to
+173
| for _, listener := range s.listeners { | ||
| listeners = append(listeners, listener) | ||
| } |
Comment on lines
+939
to
+946
| // LINSTOR cannot resize volume definitions with an exact size, so clear the | ||
| // property (it cannot be re-enabled while resources are deployed). | ||
| err = linstor.Client.ResourceDefinitions.Modify(context.TODO(), resourceDefinition.Name, linstorClient.GenericPropsModify{ | ||
| DeleteProps: []string{"DrbdOptions/ExactSize"}, | ||
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("Unable to remove the exact size property: %w", err) | ||
| } |
Contributor
There was a problem hiding this comment.
Wow that one feels weird :)
Member
Author
There was a problem hiding this comment.
Yeah, that one is a bit of a whacky LINSTOR thing... That property can't be set on resize and can't be set after a resize... So we effectively have to lose the nice accurate size reporting if we go through a resize...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.