Add PDH counter wildcard and localization support#126
Open
cbwest3 wants to merge 2 commits intolxn:masterfrom
Open
Add PDH counter wildcard and localization support#126cbwest3 wants to merge 2 commits intolxn:masterfrom
cbwest3 wants to merge 2 commits intolxn:masterfrom
Conversation
Author
|
@krpors: With your PDH experience, do you mind taking a look? tia |
Contributor
|
@cbwest Wow this has been 10 years ago already :) Anyway, I have no Windows installation anywhere to actually test the PDH stuff. I'm afraid I can't be of much help. Also, seeing my own PDH code still baffles me. I can't even remember how I got all this to work in the first place 😄 |
Author
|
Thanks @krpors, I appreciate the timely response. Best of luck in your current endeavors! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Microsoft specifies the following method for expanding wildcards and using language-neutral counters (from https://learn.microsoft.com/en-us/windows/win32/api/pdh/nf-pdh-pdhaddenglishcounterw#remarks):
Solution
The PdhAddCounter and PdhAddEnglishCounter functions already exist. This PR adds the missing PdhGetCounterInfo and PdhExpandWildCardPath functions needed to localize counter names.
These functions allow me to expand
\physicaldisk(*)\avg. disk bytes/readto:\\MYMACHINE\PhysicalDisk(0 C: F:)\Avg. Disk Bytes/Read\\MYMACHINE\PhysicalDisk(1)\Avg. Disk Bytes/Read\\MYMACHINE\PhysicalDisk(_Total)\Avg. Disk Bytes/Read