Power profiles #426

palinek · 2025-04-09T09:36:33Z

As of now: quick proof-of-concept to agree if #425 implementation would be reasonable from the user perspective and lean enough from developer perspective to include this feature into LXQt.

stefonarch · 2025-04-09T10:14:07Z

Nice work!
The Readme would need an update, ~~or also a tooltip~~ to inform that power-profiles-daemon is neededto enable it.

palinek · 2025-04-10T10:27:14Z

to inform that power-profiles-daemon is neededto enable it

Added a disabled action in case the interface is not available.

@tsujan @stefonarch @libalis
Now the implementation is fully non-blocking and also correctly reacts to outer world changes (even the service on DBus appearing/disappearing).

There is still one minor point.... do we want to support the profile names translation somehow? As those texts/names are fully dynamic and provided by the power-profile-daemon, so we have no control what can come in.

tsujan · 2025-04-10T10:38:56Z

do we want to support the profile names translation somehow?

Is there a standard way?

libalis · 2025-04-10T11:25:25Z

The power profiles now actually responds to external conditions — great job!
By the way, I’d be in favor of using translations for accessibility reasons, but only if there’s a way to guarantee enough space to prevent text from getting cut off.
The text Power profile should probably also be sent to the LXQt community for translation, right?
Regarding the icon: what is the new one supposed to represent? It’s still colorful and too small to recognize.

tsujan · 2025-04-10T12:07:29Z

It’s still colorful and too small to recognize.

These things are related to icon sets. Apps shouldn't be bothered by them.

stefonarch · 2025-04-10T12:21:53Z

There is still one minor point.... do we want to support the profile names translation somehow? As those texts/names are fully dynamic and provided by the power-profile-daemon, so we have no control what can come in.

Is there some sort of list of all possible values? It would be nice to have translations, here I've "balanced" and "power-saver" only.
Btw as usual I'd like to ship it with 2.2 ... it's a nice improvement.

libalis · 2025-04-10T14:15:01Z

These things are related to icon sets. Apps shouldn't be bothered by them.

As an app developer, you can select a reasonable default.

tsujan · 2025-04-10T15:51:11Z

As an app developer, you can select a reasonable default.

The most relevant icon is chosen here: preferences-system-performance. The shape and color of an icon are determined by the icon set.

stefonarch · 2025-04-10T16:35:05Z

As an app developer, you can select a reasonable default.

The most relevant icon is chosen here: preferences-system-performance. The shape and color of an icon are determined by the icon set.

It's also possible to choose a different icon set only for the panel.

libalis · 2025-04-10T17:10:52Z

The most relevant icon is chosen here: preferences-system-performance. The shape and color of an icon are determined by the icon set.

Didn't know that was the selected icon, if you want to stick to the xdg standard that's probably a really good choice, sorry.

It's also possible to choose a different icon set only for the panel.

This doesn't work for individual widgets, but no problem, thank you!

..to leave the under-the-hood algorithm be driven by QPA platform theme.

The power profiles setting is made available by freedesktop's power-profiles-daemon. We just provide basic functionality in case DBus interface is available in runtime.

We have no control over the profile names returned by power-profiles-daemon. We have just added basic profile names as seen being used.

palinek · 2025-04-11T07:41:33Z

Added basic translation support -> just profile name strings of power-profiles-daemon I've seen in my setup.
Rebased to current master.

Now, I believe, this is read for final review/merge.

palinek · 2025-04-11T07:46:32Z

Closes #425

tsujan · 2025-04-11T08:01:19Z

Please remove the ts files from the PR.

palinek · 2025-04-11T08:24:41Z

What's the problem with updated ts files? @stefonarch would update it the same way.

tsujan · 2025-04-11T08:28:51Z

The advantage: A much cleaner and readable patch that contains only the relevant changes. That's why the translation PRs are always made separately (by @stefonarch).

tsujan · 2025-04-11T08:42:59Z

src/PowerProfiles.cpp

+            mActions.reset(nullptr);
+            mMenu->addAction(tr("power-profiles-daemon not available"))->setDisabled(true);
+            return;
+        }


I'm a little uncomfortable about showing the new menu-item when power-profiles-daemon isn't available. This may pretend that power-profiles-daemon is preferred by LXQt, while many users may install tlp, which is in conflict with it.

IMHO, this deserves a discussion before merging.

Well we don't necessarily depend on power-profiles-daemon, but on provided DBus service. Should we rather use org.freedesktop.UPower.PowerProfiles DBus service not available?

power-profiles-daemon is an actual package that the user can install to fix the problem, so it is much more user friendly imo.

Should we rather use …

Too technical.

Why not hiding the menu-item instead?

EDIT: I mean the Power Profile menu-item, not just its submenu.

I think that's a good solution.

Why not hiding the menu-item instead?

OK. Done

tsujan · 2025-04-11T08:46:54Z

@libalis
Just a screenshot that shows my point about icon sets:

libalis · 2025-04-11T11:15:55Z

@libalis Just a screenshot that shows my point about icon sets:

Very good illustration, thanks a lot!

tsujan

GTM, as far as I'm concerned.

If you've tested it, please merge it — it'll be a nice feature in 2.2.0 — if not, @stefonarch will be available after April 15 and could test it.

stefonarch · 2025-04-11T16:06:39Z

I'm not completely unavailable, for such a nice thing, will test it this evening but I'm confident. Translations have first to be committed in weblate, to avoid conflicts. I'll do all of them 15/16 April

tsujan · 2025-04-11T16:09:27Z

We have time until April 17 — but not a day later ;)

stefonarch · 2025-04-11T16:13:26Z

@palinek

Cloning into 'lxqt-powermanagement'...
done.
Switched to a new branch 'makepkg'
==> Starting pkgver()...
==> ERROR: pkgver is not allowed to contain colons, forward slashes, hyphens or whitespace.
==> ERROR: pkgver() generated an invalid version: power-profiles
...
...

$ git branch -M power-profiles power_profiles

No big issue but I never can build packages with your PRs directly ;)

luis-pereira · 2025-04-11T16:42:02Z

The power profile menu will only be available in a system with a battery. Systems without a battery (desktops) can also benefit from power profiles.

Well, the all tray icon functionality becomes unavailable if the the system doesn't have a battery.

palinek · 2025-04-11T17:03:29Z

Systems without a battery (desktops) can also benefit from power profiles

I already made next PR for that #428

palinek · 2025-04-11T17:12:52Z

==> ERROR: pkgver is not allowed to contain colons, forward slashes, hyphens or whitespace.

No big issue but I never can build packages with your PRs directly ;)

Heh. As I'm using dash as word separator in branch names and your build doesn't like it as it wants to use the branch name in version string.

stefonarch

Works fine.

palinek mentioned this pull request Apr 9, 2025

[Feature request] Power profiles #425

Closed

palinek force-pushed the power-profiles branch from eaf0a83 to 4e16e37 Compare April 10, 2025 10:18

palinek force-pushed the power-profiles branch 2 times, most recently from f8eeb16 to 4c20dca Compare April 11, 2025 07:34

palinek added 3 commits April 11, 2025 09:35

trayicon: Use QIcon::fromTheme()

76a0315

..to leave the under-the-hood algorithm be driven by QPA platform theme.

powerprofiles: Add support for power-profiles actions

67cd0cd

The power profiles setting is made available by freedesktop's power-profiles-daemon. We just provide basic functionality in case DBus interface is available in runtime.

powerprofiles: Add profile names translation support

1222635

We have no control over the profile names returned by power-profiles-daemon. We have just added basic profile names as seen being used.

palinek force-pushed the power-profiles branch from 4c20dca to 862967e Compare April 11, 2025 07:39

palinek marked this pull request as ready for review April 11, 2025 07:41

palinek requested review from stefonarch and tsujan April 11, 2025 07:41

tsujan reviewed Apr 11, 2025

View reviewed changes

powerprofiles: Hide power profiles menu, when API not available

6e973ca

palinek force-pushed the power-profiles branch from 862967e to 6e973ca Compare April 11, 2025 15:18

tsujan approved these changes Apr 11, 2025

View reviewed changes

stefonarch approved these changes Apr 11, 2025

View reviewed changes

palinek merged commit bff102d into master Apr 11, 2025

palinek deleted the power-profiles branch April 11, 2025 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Power profiles #426

Power profiles #426

palinek commented Apr 9, 2025

stefonarch commented Apr 9, 2025 •

edited

Loading

palinek commented Apr 10, 2025 •

edited

Loading

tsujan commented Apr 10, 2025

libalis commented Apr 10, 2025

tsujan commented Apr 10, 2025

stefonarch commented Apr 10, 2025 •

edited

Loading

libalis commented Apr 10, 2025

tsujan commented Apr 10, 2025

stefonarch commented Apr 10, 2025

libalis commented Apr 10, 2025

palinek commented Apr 11, 2025

palinek commented Apr 11, 2025

tsujan commented Apr 11, 2025

palinek commented Apr 11, 2025

tsujan commented Apr 11, 2025

tsujan Apr 11, 2025

palinek Apr 11, 2025

libalis Apr 11, 2025

tsujan Apr 11, 2025 •

edited

Loading

libalis Apr 11, 2025

palinek Apr 11, 2025

tsujan commented Apr 11, 2025

libalis commented Apr 11, 2025

tsujan left a comment

stefonarch commented Apr 11, 2025

tsujan commented Apr 11, 2025

stefonarch commented Apr 11, 2025

luis-pereira commented Apr 11, 2025

palinek commented Apr 11, 2025

palinek commented Apr 11, 2025

stefonarch left a comment

Power profiles #426

Power profiles #426

Conversation

palinek commented Apr 9, 2025

stefonarch commented Apr 9, 2025 • edited Loading

palinek commented Apr 10, 2025 • edited Loading

tsujan commented Apr 10, 2025

libalis commented Apr 10, 2025

tsujan commented Apr 10, 2025

stefonarch commented Apr 10, 2025 • edited Loading

libalis commented Apr 10, 2025

tsujan commented Apr 10, 2025

stefonarch commented Apr 10, 2025

libalis commented Apr 10, 2025

palinek commented Apr 11, 2025

palinek commented Apr 11, 2025

tsujan commented Apr 11, 2025

palinek commented Apr 11, 2025

tsujan commented Apr 11, 2025

tsujan Apr 11, 2025

Choose a reason for hiding this comment

palinek Apr 11, 2025

Choose a reason for hiding this comment

libalis Apr 11, 2025

Choose a reason for hiding this comment

tsujan Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

libalis Apr 11, 2025

Choose a reason for hiding this comment

palinek Apr 11, 2025

Choose a reason for hiding this comment

tsujan commented Apr 11, 2025

libalis commented Apr 11, 2025

tsujan left a comment

Choose a reason for hiding this comment

stefonarch commented Apr 11, 2025

tsujan commented Apr 11, 2025

stefonarch commented Apr 11, 2025

luis-pereira commented Apr 11, 2025

palinek commented Apr 11, 2025

palinek commented Apr 11, 2025

stefonarch left a comment

Choose a reason for hiding this comment

stefonarch commented Apr 9, 2025 •

edited

Loading

palinek commented Apr 10, 2025 •

edited

Loading

stefonarch commented Apr 10, 2025 •

edited

Loading

tsujan Apr 11, 2025 •

edited

Loading