Release the macOS binaries also as .tar.gz
#1642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I don't know how to test this, but I guess we'll find out if it works with the next release. |
Yeah, that's the drawback with non-portable CI pipelines. Let me know if it doesn't work and I'll gladly take a look at it. Thanks a lot @mre |
|
@mre when is the next release planned? |
|
Probably not too far into the future. I was hoping to get #1624 in, but it needs more work, so I'll probably aim for #1559 and perhaps #1648 and then we can cut a feature release, 0.19. I don't know if #1647 can be done by then as well, but we can always do another release once it's ready, so no rush. @devin-purple fyi. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to install Lychee with Ubi through Mise, and it fails in macOS because `ubi expects the binaries to be in a compressed file, and that's not the case for the macOS binaries.
This PR fixes that by also including the a
.tar.gzversion for the macOS binary.