Unify Releases Across Operating Systems #1957
Open
+183
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the Windows/macOS/Linux build into one job in the release workflow. It follows the same principle as the release build for ripgrep. Fixes #1875
Member
Author
|
On the plus-side, it's shorter. On the "minus-side" I couldn't test it. 😅 |
Somehow this was detected now in this unrelated change, but it prevents the build from getting green so I fixed it.
Member
|
Thank you for addressing the issue. I would really like to test it before blindly merging it. 😅 And it also should be possible to do so by manually triggering the workflow on a non-tagged version. Maybe we would have to temporarily update the If you don't find the time to do so, you can let me know and I'll try do it. It's just that I don't want to debug the workflow during the next release but before merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the Windows/macOS/Linux build into one job in the release workflow. It follows the same principle as the release build for ripgrep.
Fixes #1875