Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [22]
node-version: [24]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/example-minimal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24

# Build elm-watch so we can use it in this example repo.
- name: Internal cache node_modules
id: internal-cache-node_modules
uses: actions/cache@v4
with:
path: node_modules
key: internal-node_modules-ubuntu-latest-22-${{ hashFiles('package.json', 'package-lock.json') }}
key: internal-node_modules-ubuntu-latest-24-${{ hashFiles('package.json', 'package-lock.json') }}
- name: Internal npm ci
if: steps.internal-cache-node_modules.outputs.cache-hit != 'true'
run: npm ci --no-audit
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24

# Build elm-watch so we can use it in this example repo.
- name: Internal cache node_modules
id: internal-cache-node_modules
uses: actions/cache@v4
with:
path: node_modules
key: internal-node_modules-ubuntu-latest-22-${{ hashFiles('package.json', 'package-lock.json') }}
key: internal-node_modules-ubuntu-latest-24-${{ hashFiles('package.json', 'package-lock.json') }}
- name: Internal npm ci
if: steps.internal-cache-node_modules.outputs.cache-hit != 'true'
run: npm ci --no-audit
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: [20, 22]
node-version: [20, 22, 24]

env:
ELM_HOME: "${{ github.workspace }}/elm-stuff/elm-home"
Expand Down
11 changes: 9 additions & 2 deletions tests/Errors.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2444,8 +2444,15 @@ describe("errors", () => {
});

test("wrong default export, with console.log and console.error", async () => {
expect(await run("postprocess/variants/wrong-default-export", ["make"]))
.toMatchInlineSnapshot(`
const output = await run("postprocess/variants/wrong-default-export", [
"make",
]);
const normalized = output.replace(
// Only Node.js 24+ includes this line.
/\s+"module\.exports": Object\(1\),/,
"",
);
expect(normalized).toMatchInlineSnapshot(`
⧙-- MISSING POSTPROCESS DEFAULT EXPORT ------------------------------------------⧘
/Users/you/project/tests/fixtures/errors/postprocess/variants/wrong-default-export/postprocess.cjs

Expand Down
5 changes: 3 additions & 2 deletions tests/SuccessfulMake.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,15 @@ describe("successful make", () => {
// Note: It’s really difficult to tell how these align in the editor:
// - It depends on how your editor renders the emoji: 1, 1.5 or 2 columns?
// - It depends on how the ad-hoc test terminal escape interpreter handles characters of length 2.
// - The non-emoji symbol used to not count as emoji, but now it does. It’s ok, though.
expect(await run("emoji", ["make"])).toMatchInlineSnapshot(`
✅ Dependencies
✅ No emoji⧙ 1 ms Q | 1.23 s E⧘
✅ No emoji but really long target name that needs to be cut off to fit in the …
✅ 😎 Cool emoji⧙ 1 ms Q | 1.23 s E⧘
✅ 🇸🇪 Flag emoji and really long target name that needs to be cut off to fit in…
✅ 👋🏻 Skin tone⧙ 1 ms Q | 1.23 s E⧘
✅ ↪ Non-emoji symbol⧙ 1 ms Q | 1.23 s E⧘
✅ ↪ Non-emoji symbol⧙ 1 ms Q | 1.23 s E⧘
✅ ↪️ Emoji version of symbol⧙ 1 ms Q | 1.23 s E⧘

✅ Compilation finished in ⧙123 ms⧘.
Expand All @@ -272,7 +273,7 @@ describe("successful make", () => {
Cool emoji: success 1 ms Q | 1.23 s E
Flag emoji and really long target name that needs to be cut off to fit in the...
Skin tone: success 1 ms Q | 1.23 s E
Non-emoji symbol: success 1 ms Q | 1.23 s E
Non-emoji symbol: success 1 ms Q | 1.23 s E
Emoji version of symbol: success 1 ms Q | 1.23 s E

Compilation finished in 123 ms.
Expand Down
Loading