feat: add timing instrumentation to LoadingOverlay#18
Closed
Conversation
Track key milestones in the WebIframe loading pipeline: - Runtime (web-core + web-elements) initialization - Template URL assignment and shadowRoot polling - First content render detection (via MutationObserver or fallback timeout) This diagnostic data helps identify whether the 5s fallback timeout is actually triggering, and if the observer is missing early DOM insertions.
✅ Deploy Preview for lynx-go-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds performance instrumentation to WebIframe's loading pipeline to diagnose slow loading issues. Logs key milestones: runtime initialization, template loading, shadowRoot discovery, and first render detection via MutationObserver or fallback timeout.
Details
Previously, we couldn't determine if the 5-second fallback timeout was actually being hit, or if the observer callback was firing but the shadowRoot already had content (race condition).
The instrumentation outputs structured timing data to console, showing elapsed milliseconds from effect start to each phase.