Merged
Conversation
Track key milestones in the WebIframe loading pipeline: - Runtime (web-core + web-elements) initialization - Template URL assignment and shadowRoot polling - First content render detection (via MutationObserver or fallback timeout) This diagnostic data helps identify whether the 5s fallback timeout is actually triggering, and if the observer is missing early DOM insertions.
Surface errors at each stage of the loading pipeline instead of silently timing out or spinning forever: - Runtime import failure: catch ensureRuntime() rejection - Template load failure: catch fetch/parse errors in customTemplateLoader - Shadow root timeout: error after 3s if shadow root never appears - Render timeout: error after 5s if content never renders (was silent fallback) Also fixes the shadow root race condition: if children already exist when the MutationObserver is attached, mark rendered immediately.
✅ Deploy Preview for lynx-go-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Supports: ?simulateError=runtime|template|shadow|render Each value triggers the corresponding error path without modifying source code, making it easy to visually verify all error states.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error scenarios covered
Test plan
rendered (immediate)log appears when shadow root race is hit